Skip to content

Commit

Permalink
refactor: returns are not needed
Browse files Browse the repository at this point in the history
  • Loading branch information
@KeesCBakker
KeesCBakker committed Aug 29, 2023
1 parent 1509d57 commit 5c905c2
Showing 1 changed file with 38 additions and 43 deletions.
81 changes: 38 additions & 43 deletions test/pager-me-test.js
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
/*
* decaffeinate suggestions:
* DS102: Remove unnecessary code created because of implicit returns
* Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
*/
const chai = require('chai');
const sinon = require('sinon');
chai.use(require('sinon-chai'));
Expand All @@ -15,7 +10,7 @@ describe('pagerduty', function() {
before(function() {
this.triggerRegex = /(pager|major)( me)? (?:trigger|page) ((["'])([^\4]*?)\4|“([^”]*?)”|‘([^’]*?)’|([\.\w\-]+)) (.+)$/i;
this.schedulesRegex = /(pager|major)( me)? schedules( ((["'])([^]*?)\5|(.+)))?$/i;
return this.whosOnCallRegex = /who(?:’s|'s|s| is|se)? (?:on call|oncall|on-call)(?:\?)?(?: (?:for )?((["'])([^]*?)\2|(.*?))(?:\?|$))?$/i;
this.whosOnCallRegex = /who(?:’s|'s|s| is|se)? (?:on call|oncall|on-call)(?:\?)?(?: (?:for )?((["'])([^]*?)\2|(.*?))(?:\?|$))?$/i;
});

beforeEach(function() {
Expand All @@ -24,159 +19,159 @@ describe('pagerduty', function() {
hear: sinon.spy()
};

return require('../src/scripts/pagerduty')(this.robot);
require('../src/scripts/pagerduty')(this.robot);
});

it('registers a pager me listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(/pager( me)?$/i);
expect(this.robot.respond).to.have.been.calledWith(/pager( me)?$/i);
});

it('registers a pager me as listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(/pager(?: me)? as (.*)$/i);
expect(this.robot.respond).to.have.been.calledWith(/pager(?: me)? as (.*)$/i);
});

it('registers a pager forget me listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(/pager forget me$/i);
expect(this.robot.respond).to.have.been.calledWith(/pager forget me$/i);
});

it('registers a pager indcident listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? incident (.*)$/i);
it('registers a pager incident listener', function() {
expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? incident (.*)$/i);
});

it('registers a pager sup listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? (inc|incidents|sup|problems)$/i);
expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? (inc|incidents|sup|problems)$/i);
});

it('registers a pager trigger listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? (?:trigger|page) ([\w\-]+)$/i);
expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? (?:trigger|page) ([\w\-]+)$/i);
});

it('registers a pager trigger with message listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(this.triggerRegex);
expect(this.robot.respond).to.have.been.calledWith(this.triggerRegex);
});

it('registers a pager ack listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(/(?:pager|major)(?: me)? ack(?:nowledge)? (.+)$/i);
expect(this.robot.respond).to.have.been.calledWith(/(?:pager|major)(?: me)? ack(?:nowledge)? (.+)$/i);
});

it('registers a pager ack! listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? ack(nowledge)?(!)?$/i);
expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? ack(nowledge)?(!)?$/i);
});

it('registers a pager resolve listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(/(?:pager|major)(?: me)? res(?:olve)?(?:d)? (.+)$/i);
expect(this.robot.respond).to.have.been.calledWith(/(?:pager|major)(?: me)? res(?:olve)?(?:d)? (.+)$/i);
});

it('registers a pager resolve! listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? res(olve)?(d)?(!)?$/i);
expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? res(olve)?(d)?(!)?$/i);
});

it('registers a pager notes on listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? notes (.+)$/i);
expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? notes (.+)$/i);
});

it('registers a pager notes add listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? note ([\d\w]+) (.+)$/i);
expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? note ([\d\w]+) (.+)$/i);
});

it('registers a pager schedules listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(this.schedulesRegex);
expect(this.robot.respond).to.have.been.calledWith(this.schedulesRegex);
});

it('registers a pager schedule override listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? (schedule|overrides)( ((["'])([^]*?)\6|([\w\-]+)))?( ([^ ]+)\s*(\d+)?)?$/i);
expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? (schedule|overrides)( ((["'])([^]*?)\6|([\w\-]+)))?( ([^ ]+)\s*(\d+)?)?$/i);
});

it('registers a pager schedule override details listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? (override) ((["'])([^]*?)\5|([\w\-]+)) ([\w\-:\+]+) - ([\w\-:\+]+)( (.*))?$/i);
expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? (override) ((["'])([^]*?)\5|([\w\-]+)) ([\w\-:\+]+) - ([\w\-:\+]+)( (.*))?$/i);
});

it('registers a pager override delete listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? (overrides?) ((["'])([^]*?)\5|([\w\-]+)) (delete) (.*)$/i);
expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? (overrides?) ((["'])([^]*?)\5|([\w\-]+)) (delete) (.*)$/i);
});

it('registers a pager link listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(/pager( me)? (?!schedules?\b|overrides?\b|my schedule\b)(.+) (\d+)$/i);
expect(this.robot.respond).to.have.been.calledWith(/pager( me)? (?!schedules?\b|overrides?\b|my schedule\b)(.+) (\d+)$/i);
});

it('registers a pager on call listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(this.whosOnCallRegex);
expect(this.robot.respond).to.have.been.calledWith(this.whosOnCallRegex);
});

it('registers a pager services listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? services$/i);
expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? services$/i);
});

it('registers a pager maintenance listener', function() {
return expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? maintenance (\d+) (.+)$/i);
expect(this.robot.respond).to.have.been.calledWith(/(pager|major)( me)? maintenance (\d+) (.+)$/i);
});

it('trigger handles users with dots', function() {
const msg = this.triggerRegex.exec('pager trigger foo.bar baz');
expect(msg[8]).to.equal('foo.bar');
return expect(msg[9]).to.equal('baz');
expect(msg[9]).to.equal('baz');
});

it('trigger handles users with spaces', function() {
const msg = this.triggerRegex.exec('pager trigger "foo bar" baz');
expect(msg[5]).to.equal('foo bar');
return expect(msg[9]).to.equal('baz');
expect(msg[9]).to.equal('baz');
});

it('trigger handles users with spaces and single quotes', function() {
const msg = this.triggerRegex.exec("pager trigger 'foo bar' baz");
expect(msg[5]).to.equal('foo bar');
return expect(msg[9]).to.equal('baz');
expect(msg[9]).to.equal('baz');
});

it('trigger handles users without spaces', function() {
const msg = this.triggerRegex.exec('pager trigger foo bar baz');
expect(msg[8]).to.equal('foo');
return expect(msg[9]).to.equal('bar baz');
expect(msg[9]).to.equal('bar baz');
});

it('schedules handles names with quotes', function() {
const msg = this.schedulesRegex.exec('pager schedules "foo bar"');
return expect(msg[6]).to.equal('foo bar');
expect(msg[6]).to.equal('foo bar');
});

it('schedules handles names without quotes', function() {
const msg = this.schedulesRegex.exec('pager schedules foo bar');
return expect(msg[7]).to.equal('foo bar');
expect(msg[7]).to.equal('foo bar');
});

it('schedules handles names without spaces', function() {
const msg = this.schedulesRegex.exec('pager schedules foobar');
return expect(msg[7]).to.equal('foobar');
expect(msg[7]).to.equal('foobar');
});

it('whos on call handles bad input', function() {
const msg = this.whosOnCallRegex.exec('whos on callllllll');
return expect(msg).to.be.null;
expect(msg).to.be.null;
});

it('whos on call handles no schedule', function() {
const msg = this.whosOnCallRegex.exec('whos on call');
return expect(msg).to.not.be.null;
expect(msg).to.not.be.null;
});

it('whos on call handles schedules with quotes', function() {
const msg = this.whosOnCallRegex.exec('whos on call for "foo bar"');
return expect(msg[3]).to.equal('foo bar');
expect(msg[3]).to.equal('foo bar');
});

it('whos on call handles schedules with quotes and quesiton mark', function() {
const msg = this.whosOnCallRegex.exec('whos on call for "foo bar"?');
return expect(msg[3]).to.equal('foo bar');
expect(msg[3]).to.equal('foo bar');
});

it('whos on call handles schedules without quotes', function() {
const msg = this.whosOnCallRegex.exec('whos on call for foo bar');
return expect(msg[4]).to.equal('foo bar');
expect(msg[4]).to.equal('foo bar');
});

return it('whos on call handles schedules without quotes and question mark', function() {
it('whos on call handles schedules without quotes and question mark', function() {
const msg = this.whosOnCallRegex.exec('whos on call for foo bar?');
return expect(msg[4]).to.equal('foo bar');
expect(msg[4]).to.equal('foo bar');
});
});

0 comments on commit 5c905c2

Please sign in to comment.