Support paging when fetching organization members #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Organization members are a paged list in the V3 GitHub API. Previously the code would fetch only the first page of ~30 members and return that. This change switches the return to a PagedIterable<GHUser> so clients can fetch the entire organization's member list.
|
Kohsuke Kawaguchi » github-api #125 SUCCESS |
|
this looks good, can it be merged? |
rtyley
added a commit
to guardian/gu-who
that referenced
this pull request
Feb 14, 2014
...just because he got there first with the pull-request! hub4j/github-api#66 (let's hope it gets merged- if not, I can release a fork)
rtyley
added a commit
to guardian/gu-who
that referenced
this pull request
Feb 24, 2014
I've published a small fork of the github-api, which includes these pull-requests we need: hub4j/github-api#66 - org member paging hub4j/github-api#68 - org-member filtering
rtyley
added a commit
to rtyley/github-api
that referenced
this pull request
Mar 14, 2014
This fixes an issue introduced with PR hub4j#66 in commit fee02a3 - the `getMembers()` method switched to using paging, but lost the code that populated the users with a full set of values. This commit just applies 'wrapping' to all users returned, so that methods like `user.getCreatedAt()` can be called on returned users without throwing a NullPointerException - the reference to 'root' allows the user objects to populate themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Organization members are a paged list in the V3 GitHub API. Previously the code would fetch only the first page of ~30 members and return that. This change switches the return to a PagedIterable so clients can fetch the entire organization's member list.