GitHub-api 1.110 fails in creating pipeline with Blueocean #780
Comments
roymitchley
changed the title
|
Is there anything in the system log? |
|
I tried to setup a new instance. The problem occurs a step earlier when I do not already have a github connection setup. When I add the github access token and click Connect nothing happens. I did not get anything in the log then either. |
|
I think Blue Ocean may be populating data objects directly instead of via a GitHub connection. 😭 Seriously. 😭 There is a point where this library cannot save clients from themselves. There are only two options here:
If this were an API breaking change in this library, I would be inclined to go with #1. I would say the same if this were a supported or even widely used scenario. But it really isn't. Further, the fact that Blue Ocean is doing there own Jackson object mapping makes their functionality incredibly brittle. Any change to the object mapper settings (which are internal to this library) could cause Blue Ocean to break in this same way. On the other hand, I have control of this project and know how to get it updated. Whereas Blue Ocean updates are much more involved. This was reported in the Jenkins issue tracker as JENKINS-61822. |
no great options really |
Jenkins Blue Ocean made interesting design choices relating github-api interactions. They mostly reused the existing API and OM, but in a few places they chose to implement their own object mapping independent of this project. This is fine as long as nothing in this project ever changes, including internals such as ObjectMapper configuration or behavior. Recent release have made changes to those internals which break assumptions made in Blue Ocean. This change exposes this project's MappingReader and MappingWriter to allow for a fix to Blue Ocean requiring only minimal changes. This doesn't prevent future changes from breaking Blue Ocean but at least makes them much less likely. Fixes hub4j#780
|
I'm working on a release of blue ocean that should fixe this: jenkinsci/blueocean-plugin#2064 There have been some some test failures that were tough to track down. |
Describe the bug
After upgrading from github-api:1.106 to github-api:1.110 I am not able to create a new pipeline in blueocean with github as source. It fails on presenting the repositories that are available.
To Reproduce
Steps to reproduce the behaviour:
Expected behavior
A list of repositories should be presented. that should be possible to select.
I verified that after downgrading to gitbub-api:1.106 creating a new pipeline from blueocean works again.
Log output:
The text was updated successfully, but these errors were encountered: