Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getRateLimit() fails for GitHub Enterprise #78

Closed
alexwhitman opened this issue Mar 19, 2014 · 3 comments
Closed

getRateLimit() fails for GitHub Enterprise #78

alexwhitman opened this issue Mar 19, 2014 · 3 comments

Comments

@alexwhitman
Copy link

getRateLimit() at https://github.com/kohsuke/github-api/blob/master/src/main/java/org/kohsuke/github/GitHub.java#L228 fails for GitHub Enterprise with a 404 status code, body of

{
  "message": "No rate limit for white listed users"
}

GitHub Enterprise users are considered white listed and so don't have rate limits.

See also janinko/ghprb#127

@tmpapageorgiou
Copy link

I'm expiriencing this same issue. There is a issue in jenkins plugin, ghprb, https://issues.jenkins-ci.org/browse/JENKINS-22441 reporting this.

@kohsuke
Copy link
Collaborator

kohsuke commented Apr 13, 2014

I don't have access to GitHub Enterprise, so can't reproduce the problem nor verify the fix. A pull request would be greatly appreciated.

kohsuke added a commit that referenced this issue May 10, 2014
This fixes issue #78
@kohsuke
Copy link
Collaborator

kohsuke commented May 10, 2014

Fixed for 1.53.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants