Merge pull request #216 from if6was9/issue-215-download-failure

#215 fix read() failure with private repos
hub4j · Dec 1, 2015 · f9291f9 · f9291f9
2 parents c3b4ee9 + b0687db
commit f9291f9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/main/java/org/kohsuke/github/GHHooks.java b/src/main/java/org/kohsuke/github/GHHooks.java
@@ -21,8 +21,9 @@ private Context(GitHub root) {
         }
 
         public List<GHHook> getHooks() throws IOException {
-            List<GHHook> list = new ArrayList<GHHook>(Arrays.asList(
-                root.retrieve().to(collection(), collectionClass())));
+
+            GHHook [] hookArray = root.retrieve().to(collection(),collectionClass());  // jdk/eclipse bug requires this to be on separate line
+            List<GHHook> list = new ArrayList<GHHook>(Arrays.asList(hookArray));
             for (GHHook h : list)
               wrap(h);
             return list;

diff --git a/src/main/java/org/kohsuke/github/Requester.java b/src/main/java/org/kohsuke/github/Requester.java
@@ -273,8 +273,12 @@ public InputStream asStream(String tailApiUrl) throws IOException {
         while (true) {// loop while API rate limit is hit
             setupConnection(root.getApiURL(tailApiUrl));
 
-            buildRequest();
-
+
+            // if the download link is encoded with a token on the query string, the default behavior of POST will fail
+            uc.setRequestMethod("GET");
+
+            buildRequest();        
+
             try {
                 return wrapStream(uc.getInputStream());
             } catch (IOException e) {