Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Test][Docs] Security group rule supports description parameter #921

Merged
merged 1 commit into from
Feb 19, 2021
Merged

[Feature][Test][Docs] Security group rule supports description parameter #921

merged 1 commit into from
Feb 19, 2021

Conversation

Lance52259
Copy link
Contributor

What this PR does / why we need it:
Networking Security Group API supports description set and update operation, these actions can be supported by huaweicloud porvider.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #905

Special notes for your reviewer:

Release note:

1. add description parameter to provider schema, document and acc test.

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccNetworkingV2SecGroupRule_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run=TestAccNetworkingV2SecGroupRule_basic -timeout 360m -parallel 4
=== RUN   TestAccNetworkingV2SecGroupRule_basic
=== PAUSE TestAccNetworkingV2SecGroupRule_basic
=== CONT  TestAccNetworkingV2SecGroupRule_basic
--- PASS: TestAccNetworkingV2SecGroupRule_basic (48.43s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       48.476s

@Lance52259 Lance52259 changed the title [Feature][Test][docs] Security group rule supports description parameter [Feature][Test][Docs] Security group rule supports description parameter Feb 18, 2021
@ShiChangkuo ShiChangkuo merged commit b24eedd into huaweicloud:master Feb 19, 2021
@Lance52259 Lance52259 deleted the SecgroupRuleDescPatch branch February 25, 2021 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to add description field on huaweicloud_networking_secgroup_rule?
2 participants