Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Docs] Nat gateway support querying by enterprise_project_id #891

Merged
merged 2 commits into from
Feb 3, 2021
Merged

[Feature][Docs] Nat gateway support querying by enterprise_project_id #891

merged 2 commits into from
Feb 3, 2021

Conversation

Lance52259
Copy link
Contributor

@Lance52259 Lance52259 commented Feb 1, 2021

What this PR does / why we need it:
Enterprise project id is supported with Nat gateway support, but it can not be used to querying gateway list.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

NONE

Special notes for your reviewer:

Release note:

1. add enterprise project id to Nat gateway datasource.
2. fixed client exception call (natV2Client).
3. update acc test with enterprise project id.

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccNatGatewayDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run=TestAccNatGatewayDataSource_basic -timeout 360m -parallel 4
=== RUN   TestAccNatGatewayDataSource_basic
=== PAUSE TestAccNatGatewayDataSource_basic
=== CONT  TestAccNatGatewayDataSource_basic
--- PASS: TestAccNatGatewayDataSource_basic (85.88s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       85.928s

@Lance52259 Lance52259 changed the title feat: docs: nat gateway support querying by enterprise_project_id [Feature][Docs] Nat gateway support querying by enterprise_project_id Feb 2, 2021
Lance52259 and others added 2 commits February 2, 2021 11:35
- new schema parameter
- new datasource enterprise project id test example
@ShiChangkuo ShiChangkuo merged commit fe57f4a into huaweicloud:master Feb 3, 2021
@Lance52259 Lance52259 deleted the ProjectIdPatch branch February 7, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants