fix service port error when protocol is any #884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiChangkuo
reviewed
Jan 30, 2021
Comment on lines
195
to
193
| %s | ||
| %s | ||
| resource "huaweicloud_nat_dnat_rule" "dnat" { |
There was a problem hiding this comment.
please use empty lines to separate resources.
| @@ -112,10 +138,8 @@ func testAccCheckNatDnatExists() resource.TestCheckFunc { | |||
| } | |||
| } | |||
|
|
|||
| func testAccNatV2DnatRule_basic(suffix string) string { | |||
| func testAccNatV2DnatRule_res(suffix string) string { | |||
There was a problem hiding this comment.
suggest to rename the function as testAccNatV2DnatRule_base
| @@ -148,7 +172,13 @@ resource "huaweicloud_compute_instance" "instance_1" { | |||
| foo = "bar" | |||
| } | |||
| } | |||
| `, suffix, suffix, HW_AVAILABILITY_ZONE) | |||
There was a problem hiding this comment.
we also can put testAccNatPreCondition(suffix) into this function.
when "lintignore" is declared with other comments, it does not work. so we put it after "time.Sleep" in the same line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Nat dnat rule cannot create which request set with zero service port.
This issue because of isEmptyValue function return false when service port is zero(int) and program will abandom setting data.
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #880
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed