support iec flavors data source and docs #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiChangkuo
reviewed
Dec 26, 2020
| Check: resource.ComposeTestCheckFunc( | ||
| testAccCheckIECFlavorsDataSourceID(resourceName, rName), | ||
| resource.TestMatchResourceAttr(resourceName, "flavors.#", regexp.MustCompile("[1-9]\\d*")), | ||
| resource.TestCheckResourceAttr(resourceName, "region", "cn-north-4"), |
There was a problem hiding this comment.
please use the "HW_REGION_NAME" env instead of a specified region
| }) | ||
| } | ||
|
|
||
| func testAccCheckIECFlavorsDataSourceID(n, rName string) resource.TestCheckFunc { |
There was a problem hiding this comment.
the param rName is not used
Change list: 1. Remove useless function parameter rName. 2. Remove flavors name in config and remove parameter check. 3. Use HW_REGION_NAME to instead old type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run=TestAccIECFlavorsDataSource_basic -timeout 360m -parallel 4
=== RUN TestAccIECFlavorsDataSource_basic
=== PAUSE TestAccIECFlavorsDataSource_basic
=== CONT TestAccIECFlavorsDataSource_basic
--- PASS: TestAccIECFlavorsDataSource_basic (14.13s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud 14.177s