Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add data source enterprise project support #620

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

Jason-Zhang9309
Copy link
Collaborator

make testacc TEST='./huaweicloud' TESTARGS='-run TestAccEnterpriseProjectDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run TestAccEnterpriseProjectDataSource_basic -timeout 360m
=== RUN TestAccEnterpriseProjectDataSource_basic
--- PASS: TestAccEnterpriseProjectDataSource_basic (10.96s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud 11.001s

@Jason-Zhang9309
Copy link
Collaborator Author

fixes #587

"github.com/huaweicloud/golangsdk/openstack/eps/v1/enterpriseprojects"
)

func dataSourceEnterpriseProject() *schema.Resource {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use DataSourceEnterpriseProject to make it exportable.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -207,6 +207,7 @@ func Provider() terraform.ResourceProvider {
"huaweicloud_dms_az": dataSourceDmsAZV1(),
"huaweicloud_dms_product": dataSourceDmsProductV1(),
"huaweicloud_dms_maintainwindow": dataSourceDmsMaintainWindowV1(),
"huaweicloud_enterprise_project": dataSourceEnterpriseProject(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

docs/data-sources/eps.md Outdated Show resolved Hide resolved
docs/data-sources/eps.md Outdated Show resolved Hide resolved
huaweicloud/data_source_enterprise_project_test.go Outdated Show resolved Hide resolved
subcategory: "Enterprise Project Management Service (EPS)"
---

# huaweicloud\_Enterprise\_project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Enterprise/enterprise

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@niuzhenguo
Copy link
Member

better to add a list of resources which support eps.

@Jason-Zhang9309 Jason-Zhang9309 force-pushed the dev-data-source-eps branch 3 times, most recently from e61a851 to 4123c6a Compare November 2, 2020 01:55
Service Name | Resource Name
---- | ---
VPC | huaweicloud_vpc<br>huaweicloud_vpc_eip<br>huaweicloud_vpc_bandwidth<br>huaweicloud_networking_secgroup
ECS | huaweicloud_ecs_instance<br>huaweicloud_compute_instance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huaweicloud_ecs_instance is deprecated, just ignore it here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@niuzhenguo niuzhenguo merged commit 8aadf2d into huaweicloud:master Nov 2, 2020
@Jason-Zhang9309 Jason-Zhang9309 deleted the dev-data-source-eps branch November 2, 2020 08:49
@ShiChangkuo ShiChangkuo linked an issue Nov 3, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: enterprise project data source
3 participants