Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(rms): segment the target ID to ensure smooth execution of test cases #6147

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

profoundwu
Copy link
Contributor

@profoundwu profoundwu commented Jan 6, 2025

What this PR does / why we need it:
segment the target ID to ensure smooth execution of test cases
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. segment the target ID to ensure smooth execution of test cases

PR Checklist

  • Tests added/passed.
make testacc TEST="./huaweicloud/services/acceptance/rms" TESTARGS="-run TestAccResourceRmsRemediationConfiguration_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/rms -v -run TestAccResourceRmsRemediationConfiguration_basic -timeout 360m -parallel 4
=== RUN   TestAccResourceRmsRemediationConfiguration_basic
=== PAUSE TestAccResourceRmsRemediationConfiguration_basic
=== CONT  TestAccResourceRmsRemediationConfiguration_basic
--- PASS: TestAccResourceRmsRemediationConfiguration_basic (88.36s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/rms       88.423s

make testacc TEST="./huaweicloud/services/acceptance/rms" TESTARGS="-run TestAccResourceRemediationExecution_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/rms -v -run TestAccResourceRemediationExecution_basic -timeout 360m -parallel 4
=== RUN   TestAccResourceRemediationExecution_basic
=== PAUSE TestAccResourceRemediationExecution_basic
=== CONT  TestAccResourceRemediationExecution_basic
--- PASS: TestAccResourceRemediationExecution_basic (96.00s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/rms       96.112s

make testacc TEST="./huaweicloud/services/acceptance/rms" TESTARGS="-run TestAccResourceRemediationExecution_specifyResources"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/rms -v -run TestAccResourceRemediationExecution_specifyResources -timeout 360m -parallel 4
=== RUN   TestAccResourceRemediationExecution_specifyResources
=== PAUSE TestAccResourceRemediationExecution_specifyResources
=== CONT  TestAccResourceRemediationExecution_specifyResources
--- PASS: TestAccResourceRemediationExecution_specifyResources (103.38s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/rms       103.453s

make testacc TEST="./huaweicloud/services/acceptance/rms" TESTARGS="-run TestAccResourceRemediationException_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/rms -v -run TestAccResourceRemediationException_basic -timeout 360m -parallel 4
=== RUN   TestAccResourceRemediationException_basic
=== PAUSE TestAccResourceRemediationException_basic
=== CONT  TestAccResourceRemediationException_basic
--- PASS: TestAccResourceRemediationException_basic (139.17s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/rms       139.232s

make testacc TEST="./huaweicloud/services/acceptance/rms" TESTARGS="-run TestAccDataSourceRemediationExecutionStatuses_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/rms -v -run TestAccDataSourceRemediationExecutionStatuses_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceRemediationExecutionStatuses_basic
=== PAUSE TestAccDataSourceRemediationExecutionStatuses_basic
=== CONT  TestAccDataSourceRemediationExecutionStatuses_basic
--- PASS: TestAccDataSourceRemediationExecutionStatuses_basic (167.45s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/rms       167.532s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Jan 6, 2025
@luoping-12345
Copy link
Contributor

LGTM

2 similar comments
@yuanxiaojun987
Copy link

LGTM

@Alice1319
Copy link

LGTM

@Jason-Zhang9309
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Jason-Zhang9309

/approve

@github-ci-robot github-ci-robot merged commit f9569c7 into huaweicloud:master Jan 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. LGTM /lgtm size/S test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants