Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cfw): add this data source to get the list of CFW IPS basic protection rules #6146

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

profoundwu
Copy link
Contributor

What this PR does / why we need it:
add this data source to get the list of CFW IPS basic protection rules
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add this data source to get the list of CFW IPS basic protection rules

PR Checklist

  • Tests added/passed.
 make testacc TEST="./huaweicloud/services/acceptance/cfw" TESTARGS="-run TestAccDataSourceCfwIpsRules_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cfw -v -run TestAccDataSourceCfwIpsRules_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceCfwIpsRules_basic
=== PAUSE TestAccDataSourceCfwIpsRules_basic
=== CONT  TestAccDataSourceCfwIpsRules_basic
--- PASS: TestAccDataSourceCfwIpsRules_basic (154.50s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cfw       154.620s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@profoundwu profoundwu force-pushed the feat_ips_rules branch 2 times, most recently from d19443c to ee95b6c Compare January 6, 2025 11:25
@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Jan 7, 2025
@Jason-Zhang9309
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Jason-Zhang9309

/approve

@github-ci-robot github-ci-robot merged commit 41dba37 into huaweicloud:master Jan 7, 2025
14 checks passed
@profoundwu profoundwu deleted the feat_ips_rules branch January 9, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants