Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(workspace/app): using server group resource to instead corresponding env #6109

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

wuzhuanhong
Copy link
Contributor

@wuzhuanhong wuzhuanhong commented Dec 27, 2024

What this PR does / why we need it:

Adjust some acceptance tests.

  • Remove HW_WORKSPACE_APP_SERVER_GROUP_ID and use the server group resource instead.
  • Remove the service name (Workspace) from the test case name.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. remove HW_WORKSPACE_APP_SERVER_GROUP_ID and use the server group resource instead.
2. remove the service name (Workspace) from the test case name.

PR Checklist

  • Tests added/passed.
/scripts/coverage.sh -o workspace -f '^(TestAccResourceAppGroupAuthorization_basic|ResourceAppGroupAuthorization_expectErr|TestAccAppPolicyGroup_basic|TestAccAppPublishment_basic|TestAccDataSourceAppGroups_basic|TestAccResourceAppGroup_basic)$'
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run ^(TestAccResourceAppGroupAuthorization_basic|ResourceAppGroupAuthorization_expectErr|TestAccAppPolicyGroup_basic|TestAccAppPublishment_basic|TestAccDataSourceAppGroups_basic|TestAccResourceAppGroup_basic)$ -timeout 360m -parallel 10
=== RUN   TestAccDataSourceAppGroups_basic
=== PAUSE TestAccDataSourceAppGroups_basic
=== RUN   TestAccResourceAppGroupAuthorization_basic
=== PAUSE TestAccResourceAppGroupAuthorization_basic
=== RUN   TestAccResourceAppGroup_basic
=== PAUSE TestAccResourceAppGroup_basic
=== RUN   TestAccAppPolicyGroup_basic
=== PAUSE TestAccAppPolicyGroup_basic
=== RUN   TestAccAppPublishment_basic
=== PAUSE TestAccAppPublishment_basic
=== CONT  TestAccDataSourceAppGroups_basic
=== CONT  TestAccAppPolicyGroup_basic
=== CONT  TestAccAppPublishment_basic
=== CONT  TestAccResourceAppGroup_basic
=== CONT  TestAccResourceAppGroupAuthorization_basic
--- PASS: TestAccResourceAppGroup_basic (147.00s)
--- PASS: TestAccResourceAppGroupAuthorization_basic (169.56s)
--- PASS: TestAccAppPublishment_basic (176.32s)
--- PASS: TestAccDataSourceAppGroups_basic (185.95s)
--- PASS: TestAccAppPolicyGroup_basic (213.67s)
PASS
coverage: 19.2% of statements in ./huaweicloud/services/workspace
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 213.737s        coverage: 19.2% of statements in ./huaweicloud/services/workspace
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@wuzhuanhong wuzhuanhong changed the title test(workspace/app): adjust some acceptance tests test(workspace/app): using server group resource to instead corresponding env Dec 27, 2024
@Lance52259
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 27, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit b285da2 into huaweicloud:master Dec 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. LGTM /lgtm size/S test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants