Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cfw): add the fw_instance_id query parameter in the URL for the create domain name group request #6106

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

profoundwu
Copy link
Contributor

What this PR does / why we need it:
add the fw_instance_id query parameter in the URL for the create domain name group request
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add the fw_instance_id query parameter in the URL for the create domain name group request

PR Checklist

  • Tests added/passed.
make testacc TEST="./huaweicloud/services/acceptance/cfw" TESTARGS="-run TestAccDomainNameGroup_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cfw -v -run TestAccDomainNameGroup_basic -timeout 360m -parallel 4
=== RUN   TestAccDomainNameGroup_basic
=== PAUSE TestAccDomainNameGroup_basic
=== CONT  TestAccDomainNameGroup_basic
--- PASS: TestAccDomainNameGroup_basic (442.18s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cfw       442.323s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@Jason-Zhang9309
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 27, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Jason-Zhang9309

/approve

@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 30, 2024
@github-ci-robot github-ci-robot merged commit d48b9f2 into huaweicloud:master Dec 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugfix LGTM /lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants