Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(live): support a new resource to manage live stream delay #6103

Merged

Conversation

deer-hang
Copy link
Contributor

@deer-hang deer-hang commented Dec 26, 2024

What this PR does / why we need it:

support a new resource to manage live stream delay

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/live' TESTARGS='-run TestAccResourceStreamDelay_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/live -v -run TestAccResourceStreamDelay_basic -timeout 360m -parallel 4
=== RUN   TestAccResourceStreamDelay_basic
=== PAUSE TestAccResourceStreamDelay_basic
=== CONT  TestAccResourceStreamDelay_basic
--- PASS: TestAccResourceStreamDelay_basic (14.97s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      15.020s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 26, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @deer-hang

@deer-hang deer-hang force-pushed the feat-live-resource-stream-delay branch from 31c9be5 to 257dfdb Compare December 26, 2024 09:16
@jinyangyang222
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 27, 2024
@github-ci-robot github-ci-robot merged commit e22a96d into huaweicloud:master Dec 27, 2024
16 checks passed
@deer-hang deer-hang deleted the feat-live-resource-stream-delay branch December 28, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants