-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rms): RMS organizational assignment package supports updates #6100
Merged
github-ci-robot
merged 1 commit into
huaweicloud:master
from
profoundwu:feat_rms_org_assignment_package
Dec 27, 2024
Merged
feat(rms): RMS organizational assignment package supports updates #6100
github-ci-robot
merged 1 commit into
huaweicloud:master
from
profoundwu:feat_rms_org_assignment_package
Dec 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profoundwu
force-pushed
the
feat_rms_org_assignment_package
branch
3 times, most recently
from
December 26, 2024 08:18
3735823
to
0f582a5
Compare
profoundwu
force-pushed
the
feat_rms_org_assignment_package
branch
2 times, most recently
from
December 27, 2024 01:48
e19202f
to
1193c20
Compare
houpeng80
reviewed
Dec 27, 2024
} | ||
|
||
if _, err = stateConf.WaitForStateContext(ctx); err != nil { | ||
return diag.Errorf("error waiting for RMS organizational assignment Package (%s) to be updated: %s", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
return diag.Errorf("error waiting for RMS organizational assignment Package (%s) to be updated: %s", | |
return diag.Errorf("error waiting for RMS organizational assignment package (%s) to be updated: %s", |
profoundwu
force-pushed
the
feat_rms_org_assignment_package
branch
from
December 27, 2024 06:40
1193c20
to
b1fa2cc
Compare
/lgtm |
/approve |
github-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Dec 27, 2024
github-ci-robot
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been approved by: @Jason-Zhang9309
/approve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
RMS organizational assignment package supports updates
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Documentation updated.
Schema updated.
CheckDeleted.
a. During query operation (Read Context)
aa. Resource not found
>>>>>> Paste the screenshot here <<<<<<
b. During delete/disassociate/unbind operation (Delete Context)
ba. Resource not found
>>>>>> Paste the screenshot here <<<<<<