Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rms): RMS organizational assignment package supports updates #6100

Merged

Conversation

profoundwu
Copy link
Contributor

@profoundwu profoundwu commented Dec 26, 2024

What this PR does / why we need it:
RMS organizational assignment package supports updates
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. RMS organizational assignment package supports updates

PR Checklist

  • Tests added/passed.
$make testacc TEST="./huaweicloud/services/acceptance/rms/" TESTARGS="-run Test AccOrgAssignmentPackagee_basic"
TF_ACC=1 go test ./huaweicloud/services/acceptance/rms/ -v -run TestAccOrgAssignmentPackage_basic -timeout 360m -parallel 4
=== RUN TestAccOrgAssignmentPackage_basic
=== PAUSE TestAccOrgAssignmentPackage_basic
=== CONT TestAccOrgAssignmentPackage_basic
----- PASS: TestAccOrgAssignmentPackage_baisc (171.05s)
PASS
ok         github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/rms 188.947s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@profoundwu profoundwu force-pushed the feat_rms_org_assignment_package branch 3 times, most recently from 3735823 to 0f582a5 Compare December 26, 2024 08:18
@profoundwu profoundwu force-pushed the feat_rms_org_assignment_package branch 2 times, most recently from e19202f to 1193c20 Compare December 27, 2024 01:48
}

if _, err = stateConf.WaitForStateContext(ctx); err != nil {
return diag.Errorf("error waiting for RMS organizational assignment Package (%s) to be updated: %s",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return diag.Errorf("error waiting for RMS organizational assignment Package (%s) to be updated: %s",
return diag.Errorf("error waiting for RMS organizational assignment package (%s) to be updated: %s",

@profoundwu profoundwu force-pushed the feat_rms_org_assignment_package branch from 1193c20 to b1fa2cc Compare December 27, 2024 06:40
@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 27, 2024
@Jason-Zhang9309
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 27, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Jason-Zhang9309

/approve

@github-ci-robot github-ci-robot merged commit 1012b69 into huaweicloud:master Dec 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants