Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CodeArts/Deploy): fix check delete for application #6089

Conversation

saf3dfsa
Copy link
Contributor

@saf3dfsa saf3dfsa commented Dec 25, 2024

What this PR does / why we need it:
fix check delete for application
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

fix check delete for application

PR Checklist

  • Tests added/passed.
make testacc TEST="./huaweicloud/services/acceptance/codeartsdeploy" TESTARGS="-run  TestAccDeployApplication_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/codeartsdeploy -v -run  TestAccDeployApplication_basic -timeout 360m -parallel 4
=== RUN   TestAccDeployApplication_basic
=== PAUSE TestAccDeployApplication_basic
=== CONT  TestAccDeployApplication_basic
--- PASS: TestAccDeployApplication_basic (29.54s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/codeartsdeploy    29.584s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image

@houpeng80
Copy link
Collaborator

/lgtm
/approve

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 25, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @houpeng80

/lgtm
/approve

@github-ci-robot github-ci-robot merged commit e646144 into huaweicloud:master Dec 25, 2024
17 checks passed
@saf3dfsa saf3dfsa deleted the fix(CodeArts/Deploy)_fix_check_delete_for_application branch December 26, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugfix LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants