-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(servicestage/auth): host parameter is no longer required #6079
Merged
github-ci-robot
merged 2 commits into
huaweicloud:master
from
Lance52259:br_servicestage_token_authorization_refactor
Dec 24, 2024
Merged
chore(servicestage/auth): host parameter is no longer required #6079
github-ci-robot
merged 2 commits into
huaweicloud:master
from
Lance52259:br_servicestage_token_authorization_refactor
Dec 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Dec 24, 2024
[APPROVALNOTIFIER] This PR is APPROVED This PR has been approved by: @Lance52259 |
Lance52259
force-pushed
the
br_servicestage_token_authorization_refactor
branch
2 times, most recently
from
December 24, 2024 08:26
f03f8db
to
c7eb9a3
Compare
|
deer-hang
reviewed
Dec 24, 2024
@@ -20,7 +20,6 @@ variable "personal_access_token" | |||
resource "huaweicloud_servicestage_repo_token_authorization" "test" { | |||
type = "github" | |||
name = var.authorization_name | |||
host = var.repository_host |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove variable repository_host
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Lance52259
force-pushed
the
br_servicestage_token_authorization_refactor
branch
from
December 24, 2024 08:52
c7eb9a3
to
a933989
Compare
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
chore
dependencies
LGTM
/lgtm
size/M
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
During the OpenAPI upgradation, the behavior of parameter host is changed from required to optional.
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Documentation updated.
Schema updated.
CheckDeleted.
a. During query operation (Read Context)
aa. Resource not found
>>>>>> Paste the screenshot here <<<<<<
b. During delete/disassociate/unbind operation (Delete Context)
ba. Resource not found
>>>>>> Paste the screenshot here <<<<<<