Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(servicestage/auth): host parameter is no longer required #6079

Conversation

Lance52259
Copy link
Contributor

What this PR does / why we need it:
During the OpenAPI upgradation, the behavior of parameter host is changed from required to optional.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. update the behavior of the parameter host from required to optional.

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o servicestage -f TestAccRepoTokenAuth_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/servicestage" -v -coverprofile="./huaweicloud/services/acceptance/servicestage/servicestage_coverage.cov" -coverpkg="./huaweicloud/services/servicestage" -run TestAccRepoTokenAuth_basic -timeout 360m -parallel 10
=== RUN   TestAccRepoTokenAuth_basic
=== PAUSE TestAccRepoTokenAuth_basic
=== CONT  TestAccRepoTokenAuth_basic
--- PASS: TestAccRepoTokenAuth_basic (10.58s)
PASS
coverage: 3.9% of statements in ./huaweicloud/services/servicestage
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/servicestage      10.630s coverage: 3.9% of statements in ./huaweicloud/services/servicestage
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Lance52259

@Lance52259 Lance52259 force-pushed the br_servicestage_token_authorization_refactor branch 2 times, most recently from f03f8db to c7eb9a3 Compare December 24, 2024 08:26
@github-actions github-actions bot added size/M and removed size/S labels Dec 24, 2024
@Lance52259
Copy link
Contributor Author

./scripts/coverage.sh -o servicestage -f TestAccRepoTokenAuth_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/servicestage" -v -coverprofile="./huaweicloud/services/acceptance/servicestage/servicestage_coverage.cov" -coverpkg="./huaweicloud/services/servicestage" -run TestAccRepoTokenAuth_basic -timeout 360m -parallel 10
=== RUN   TestAccRepoTokenAuth_basic
=== PAUSE TestAccRepoTokenAuth_basic
=== CONT  TestAccRepoTokenAuth_basic
--- PASS: TestAccRepoTokenAuth_basic (12.71s)
PASS
coverage: 3.9% of statements in ./huaweicloud/services/servicestage
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/servicestage      12.757s coverage: 3.9% of statements in ./huaweicloud/services/servicestage

@@ -20,7 +20,6 @@ variable "personal_access_token"
resource "huaweicloud_servicestage_repo_token_authorization" "test" {
type = "github"
name = var.authorization_name
host = var.repository_host
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove variable repository_host.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@Lance52259 Lance52259 force-pushed the br_servicestage_token_authorization_refactor branch from c7eb9a3 to a933989 Compare December 24, 2024 08:52
@deer-hang
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 24, 2024
@github-ci-robot github-ci-robot merged commit 68dcbb7 into huaweicloud:master Dec 24, 2024
13 checks passed
@Lance52259 Lance52259 deleted the br_servicestage_token_authorization_refactor branch December 25, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. chore dependencies LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants