-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(live): add a new resource to manage notification cofiguration #6071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruwenqiang123
force-pushed
the
dev_notice
branch
from
December 23, 2024 03:33
0546287
to
9a84b4c
Compare
ruwenqiang123
force-pushed
the
dev_notice
branch
from
December 23, 2024 03:47
9a84b4c
to
c2608bf
Compare
huaweicloud/services/live/resource_huaweicloud_live_notification_cofiguration.go
Show resolved
Hide resolved
ruwenqiang123
force-pushed
the
dev_notice
branch
from
December 23, 2024 07:09
c2608bf
to
f57a213
Compare
deer-hang
reviewed
Dec 23, 2024
deer-hang
reviewed
Dec 23, 2024
deer-hang
reviewed
Dec 23, 2024
deer-hang
reviewed
Dec 23, 2024
huaweicloud/services/live/resource_huaweicloud_live_notification_cofiguration.go
Outdated
Show resolved
Hide resolved
ruwenqiang123
force-pushed
the
dev_notice
branch
from
December 23, 2024 09:54
f57a213
to
7f96064
Compare
|
/approve |
github-ci-robot
added
LGTM
/lgtm
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
labels
Dec 24, 2024
github-ci-robot
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been approved by: @deer-hang
/approve
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a new resource to manage notification cofiguration.
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Documentation updated.
Schema updated.
CheckDeleted.
aa. Resource not found
>>>>>> Paste the screenshot here <<<<<<
ba. Resource not found
>>>>>> Paste the screenshot here <<<<<<