Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(live): add a new resource to generate a sign URL #6064

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

ruwenqiang123
Copy link
Contributor

@ruwenqiang123 ruwenqiang123 commented Dec 19, 2024

What this PR does / why we need it:

Add a new resource to generate a sign URL.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. support a new resource to generate a sign URL.
2. 2.support related document and acceptance test.

PR Checklist

  • Tests added/passed.
$ make testacc TEST="./huaweicloud/services/acceptance/live" TESTARGS="-run TestAccUrlAuthentication_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/live -v -run TestAccUrlAuthentication_basic -timeout 360m -parallel 4
=== RUN   TestAccUrlAuthentication_basic
=== PAUSE TestAccUrlAuthentication_basic
=== CONT  TestAccUrlAuthentication_basic
--- PASS: TestAccUrlAuthentication_basic (433.68s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      433.771s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@ruwenqiang123 ruwenqiang123 changed the title [WIP] feat(live): add a new resource to generate a sign URL feat(live): add a new resource to generate a sign URL Dec 20, 2024
@ruwenqiang123 ruwenqiang123 force-pushed the dev_sign branch 2 times, most recently from b5d4b8c to bd9f9c1 Compare December 20, 2024 03:45
@ruwenqiang123
Copy link
Contributor Author

$ make testacc TEST="./huaweicloud/services/acceptance/live" TESTARGS="-run TestAccUrlAuthentication_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/live -v -run TestAccUrlAuthentication_basic -timeout 360m -parallel 4
=== RUN   TestAccUrlAuthentication_basic
=== PAUSE TestAccUrlAuthentication_basic
=== CONT  TestAccUrlAuthentication_basic
--- PASS: TestAccUrlAuthentication_basic (392.81s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      392.862s

@ruwenqiang123
Copy link
Contributor Author

$ make testacc TEST="./huaweicloud/services/acceptance/live" TESTARGS="-run TestAccUrlAuthentication_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/live -v -run TestAccUrlAuthentication_basic -timeout 360m -parallel 4
=== RUN   TestAccUrlAuthentication_basic
=== PAUSE TestAccUrlAuthentication_basic
=== CONT  TestAccUrlAuthentication_basic
--- PASS: TestAccUrlAuthentication_basic (371.96s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      372.004s

@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 24, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 0fd6ae1 into huaweicloud:master Dec 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants