Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CodeArts/Deploy): support to copy host #6053

Merged
merged 1 commit into from
Dec 24, 2024
Merged

feat(CodeArts/Deploy): support to copy host #6053

merged 1 commit into from
Dec 24, 2024

Conversation

saf3dfsa
Copy link
Contributor

@saf3dfsa saf3dfsa commented Dec 18, 2024 •
edited
Loading

What this PR does / why we need it:
support to copy host

PR Checklist

  • Tests added/passed.
make testacc TEST="./huaweicloud/services/acceptance/codeartsdeploy" TESTARGS="-run  TestAccCodeArtsDeployHostsCopy_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/codeartsdeploy -v -run  TestAccCodeArtsDeployHostsCopy_basic -timeout 360m -parallel 4
=== RUN   TestAccCodeArtsDeployHostsCopy_basic
=== PAUSE TestAccCodeArtsDeployHostsCopy_basic
=== CONT  TestAccCodeArtsDeployHostsCopy_basic
--- PASS: TestAccCodeArtsDeployHostsCopy_basic (233.04s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/codeartsdeploy    233.148s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@saf3dfsa saf3dfsa force-pushed the feat(CodeArts/Deploy)_support_to_copy_host branch 4 times, most recently from a431a2f to 86c6fbb Compare December 23, 2024 07:51
@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 23, 2024
@houpeng80
Copy link
Collaborator

/lgtm

@saf3dfsa saf3dfsa force-pushed the feat(CodeArts/Deploy)_support_to_copy_host branch from 86c6fbb to 6c7ced0 Compare December 24, 2024 03:22
@houpeng80
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2024
github-ci-robot
github-ci-robot approved these changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @houpeng80

/approve

@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 24, 2024
@github-ci-robot github-ci-robot merged commit 9752bac into huaweicloud:master Dec 24, 2024
14 checks passed
@saf3dfsa saf3dfsa deleted the feat(CodeArts/Deploy)_support_to_copy_host branch December 26, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-ci-robot github-ci-robot github-ci-robot approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saf3dfsa @Jason-Zhang9309 @houpeng80 @github-ci-robot