Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(live): Optimize resource code to record callback resource #6038

Merged

Conversation

deer-hang
Copy link
Contributor

@deer-hang deer-hang commented Dec 17, 2024

What this PR does / why we need it:

  • Optimize some code logic and test cases to record callback resource.
  • Optimize the document description of this resource.
  • Add two new fields sign_type and key.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/live' TESTARGS='-run TestAccRecordCallback_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/live -v -run TestAccRecordCallback_basic -timeout 360m -parallel 4
=== RUN   TestAccRecordCallback_basic
--- PASS: TestAccRecordCallback_basic (14.46s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      14.505s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @deer-hang

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@deer-hang deer-hang changed the title chore(live): Optimize some code logic and test cases to record callback resource chore(live): Optimize resource code to record callback resource Dec 17, 2024
@jinyangyang222
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 17, 2024
@github-ci-robot github-ci-robot merged commit db3613f into huaweicloud:master Dec 17, 2024
20 checks passed
@deer-hang deer-hang deleted the chore-live-record-callback branch December 18, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. chore LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants