Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lts): the log stream supports modifying ttl_in_days field #6037

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

wuzhuanhong
Copy link
Contributor

What this PR does / why we need it:

The log stream resource and data source supports modifying ttl_in_days field.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

the log stream supports modifying ttl_in_days field.

PR Checklist

  • Tests added/passed.
 ./scripts/coverage.sh -o lts -f TestAccLtsStream
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/lts" -v -coverprofile="./huaweicloud/services/acceptance/lts/lts_coverage.cov" -coverpkg="./huaweicloud/services/lts" -run TestAccLtsStream -timeout 360m -parallel 10
=== RUN   TestAccLtsStream_basic
=== PAUSE TestAccLtsStream_basic
=== RUN   TestAccLtsStream_epsId
=== PAUSE TestAccLtsStream_epsId
=== CONT  TestAccLtsStream_basic
=== CONT  TestAccLtsStream_epsId
--- PASS: TestAccLtsStream_epsId (48.31s)
--- PASS: TestAccLtsStream_basic (77.86s)
PASS
coverage: 9.9% of statements in ./huaweicloud/services/lts
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/lts       77.937s coverage: 9.9% of statements in ./huaweicloud/services/lts

./scripts/coverage.sh -o lts -f TestAccDataSourceStreams_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/lts" -v -coverprofile="./huaweicloud/services/acceptance/lts/lts_coverage.cov" -coverpkg="./huaweicloud/services/lts" -run TestAccDataSourceStreams_basic -timeout 360m -parallel 10
=== RUN   TestAccDataSourceStreams_basic
=== PAUSE TestAccDataSourceStreams_basic
=== CONT  TestAccDataSourceStreams_basic
--- PASS: TestAccDataSourceStreams_basic (156.98s)
PASS
coverage: 9.6% of statements in ./huaweicloud/services/lts
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/lts       157.036s        coverage: 9.6% of statements in ./huaweicloud/services/lts
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

}
_, err := client.Request("PUT", updatePath, &updateOpt)
if err != nil {
return fmt.Errorf("error updating ttl_in_days of the log stream (%s): (%s)", logStreamId, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return fmt.Errorf("error updating ttl_in_days of the log stream (%s): (%s)", logStreamId, err)
return fmt.Errorf("error updating ttl_in_days of the log stream (%s): %s", logStreamId, err)

@Lance52259
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 17, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 39e78ac into huaweicloud:master Dec 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants