Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(live): Optimize resource code to recording resource #6033

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

deer-hang
Copy link
Contributor

@deer-hang deer-hang commented Dec 16, 2024

What this PR does / why we need it:

  • Optimize some code logic and test cases.
  • Improve the content description of the document.
  • Add a new field record_slice_duration.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
go test -v -coverprofile=coverage_1734347540886_TestAccRecording_basic.cov -coverpkg=./huaweicloud/services/live ./huaweicloud/services/acceptance/live -run TestAccRecording_basic -timeout 360m -parallel 4
=== RUN   TestAccRecording_basic
--- PASS: TestAccRecording_basic (25.16s)
PASS
coverage: 11.2% of statements in ./huaweicloud/services/live
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      25.216s coverage: 11.2% of statements in ./huaweicloud/services/live
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @deer-hang

@deer-hang deer-hang force-pushed the chore-live-recording branch 3 times, most recently from 07bb49d to e350bbd Compare December 17, 2024 03:12
@deer-hang deer-hang changed the title chore(live): Optimize some code logic and test cases chore(live): Optimize resource code to recording resource Dec 17, 2024
@deer-hang deer-hang force-pushed the chore-live-recording branch from e350bbd to 5178239 Compare December 18, 2024 01:51
@jinyangyang222
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 18, 2024
@github-ci-robot github-ci-robot merged commit 2a257bf into huaweicloud:master Dec 18, 2024
13 checks passed
@deer-hang deer-hang deleted the chore-live-recording branch December 18, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. chore LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants