Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(servicestage): add new data source to query components #6032

Merged

Conversation

Lance52259
Copy link
Contributor

What this PR does / why we need it:
Supports a new data source that used to query ServiceStage components via ver.3 OpenAPIs.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add new data source to query components.

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o servicestage -f TestAccDataV3Components_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/servicestage" -v -coverprofile="./huaweicloud/services/acceptance/servicestage/servicestage_coverage.cov" -coverpkg="./huaweicloud/services/servicestage" -run TestAccDataV3Components_basic -timeout 360m -parallel 10
=== RUN   TestAccDataV3Components_basic
=== PAUSE TestAccDataV3Components_basic
=== CONT  TestAccDataV3Components_basic
--- PASS: TestAccDataV3Components_basic (349.62s)
PASS
coverage: 29.3% of statements in ./huaweicloud/services/servicestage
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/servicestage      349.688s        coverage: 29.3% of statements in ./huaweicloud/services/servicestage
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Lance52259

@Lance52259 Lance52259 force-pushed the br_servicestage_data_components branch 4 times, most recently from 626ea3e to 8dd72fd Compare December 17, 2024 02:44
@Lance52259 Lance52259 force-pushed the br_servicestage_data_components branch from 8dd72fd to 27bd3fa Compare December 17, 2024 02:45
@deer-hang
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 17, 2024
@github-ci-robot github-ci-robot merged commit b1510da into huaweicloud:master Dec 17, 2024
13 checks passed
@Lance52259 Lance52259 deleted the br_servicestage_data_components branch December 17, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants