Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(waf): dedicated instance resource support field tags #6029

Merged

Conversation

deer-hang
Copy link
Contributor

@deer-hang deer-hang commented Dec 16, 2024

What this PR does / why we need it:

WAF dedicated instance resource support field tags.
This field is not editable and has no corresponding value.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/waf' TESTARGS='-run TestAccDedicatedInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/waf -v -run TestAccDedicatedInstance_basic -timeout 360m -parallel 4
=== RUN   TestAccDedicatedInstance_basic
=== PAUSE TestAccDedicatedInstance_basic
=== CONT  TestAccDedicatedInstance_basic
--- PASS: TestAccDedicatedInstance_basic (455.20s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/waf       455.243s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @deer-hang

@jinyangyang222
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 16, 2024
@github-ci-robot github-ci-robot merged commit 22d3268 into huaweicloud:master Dec 16, 2024
17 checks passed
@deer-hang deer-hang deleted the waf-dedicated-support-tags branch December 17, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies feature LGTM /lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants