Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(live): add a new resource to manage disable a push stream #6027

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

ruwenqiang123
Copy link
Contributor

What this PR does / why we need it:

Add a new resource to manage disable a push stream.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1.support a new resource to manage disable a push stream.
2.support related document and acceptance test.

PR Checklist

  • Tests added/passed.
$ make testacc TEST="./huaweicloud/services/acceptance/live" TESTARGS="-run TestAccDisablePushStream_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/live -v -run TestAccDisablePushStream_basic -timeout 360m -parallel 4
=== RUN   TestAccDisablePushStream_basic
=== PAUSE TestAccDisablePushStream_basic
=== CONT  TestAccDisablePushStream_basic
--- PASS: TestAccDisablePushStream_basic (270.32s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      270.370s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image
    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image
      image

@ruwenqiang123 ruwenqiang123 force-pushed the dev_block branch 2 times, most recently from 576410d to 7191a1e Compare December 17, 2024 06:45
@ruwenqiang123
Copy link
Contributor Author

$ make testacc TEST="./huaweicloud/services/acceptance/live" TESTARGS="-run TestAccDisablePushStream_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/live -v -run TestAccDisablePushStream_basic -timeout 360m -parallel 4
=== RUN   TestAccDisablePushStream_basic
=== PAUSE TestAccDisablePushStream_basic
=== CONT  TestAccDisablePushStream_basic
--- PASS: TestAccDisablePushStream_basic (238.02s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      238.075s

@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 18, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 9b9c9d3 into huaweicloud:master Dec 18, 2024
14 checks passed
@ruwenqiang123 ruwenqiang123 deleted the dev_block branch December 30, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants