Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(live): support a new datasource to query snapshots #6025

Merged

Conversation

deer-hang
Copy link
Contributor

What this PR does / why we need it:

Support a new datasource to query snapshots.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/live' TESTARGS='-run TestAccDataSourceSnapshots_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/live -v -run TestAccDataSourceSnapshots_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceSnapshots_basic
=== PAUSE TestAccDataSourceSnapshots_basic
=== CONT  TestAccDataSourceSnapshots_basic
--- PASS: TestAccDataSourceSnapshots_basic (11.72s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      11.759s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @deer-hang

@deer-hang deer-hang force-pushed the datasource-live-snapshots branch from 5649cf6 to e3ce4a6 Compare December 16, 2024 03:33
@jinyangyang222
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 16, 2024
@github-ci-robot github-ci-robot merged commit f3e2a1d into huaweicloud:master Dec 16, 2024
13 checks passed
@deer-hang deer-hang deleted the datasource-live-snapshots branch December 17, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants