Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(geip): fix error when gcb is empty #6014

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix(geip): fix error when gcb is empty #6014

merged 1 commit into from
Dec 13, 2024

Conversation

saf3dfsa
Copy link
Contributor

@saf3dfsa saf3dfsa commented Dec 13, 2024 •
edited
Loading

What this PR does / why we need it:
fix error when gcb is empty

PR Checklist

  • Tests added/passed.
make testacc TEST="./huaweicloud/services/acceptance/eip" TESTARGS="-run TestAccGEIPAssociate_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/eip -v -run TestAccGEIPAssociate_basic -timeout 360m -parallel 4
=== RUN   TestAccGEIPAssociate_basic
=== PAUSE TestAccGEIPAssociate_basic
=== CONT  TestAccGEIPAssociate_basic
--- PASS: TestAccGEIPAssociate_basic (275.75s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/eip       275.792s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@houpeng80
Copy link
Collaborator

/lgtm
/approve

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 13, 2024
github-ci-robot
github-ci-robot approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @houpeng80

/lgtm
/approve

@github-ci-robot github-ci-robot merged commit 6876e8c into huaweicloud:master Dec 13, 2024
14 checks passed
@saf3dfsa saf3dfsa deleted the fix(geip)_fix_error_when_gcb_is_empty branch December 26, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-ci-robot github-ci-robot github-ci-robot approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugfix LGTM /lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saf3dfsa @houpeng80 @github-ci-robot