Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(identitycenter): add resource identitycenter access control attribute config #5983

Merged

Conversation

luoping-12345
Copy link
Contributor

@luoping-12345 luoping-12345 commented Dec 9, 2024

What this PR does / why we need it:
add resource identitycenter access control attribute config

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

add resource identitycenter access control attribute config

PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccSomethingV0_basic'
...
=== RUN   TestAccSomethingV0_basic
--- PASS: TestAccSomethingV0_basic (70.75s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       70.796s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@luoping-12345 luoping-12345 force-pushed the identitycenter_attr_conf branch from 37c9b62 to bcd4974 Compare December 12, 2024 11:11
@luoping-12345 luoping-12345 changed the title [WIP] feat(identitycenter): add resource identitycenter access control attribute config feat(identitycenter): add resource identitycenter access control attribute config Dec 12, 2024
@luoping-12345 luoping-12345 force-pushed the identitycenter_attr_conf branch 3 times, most recently from 7bc992c to d058725 Compare December 17, 2024 03:12
@github-actions github-actions bot added size/L and removed size/M labels Dec 17, 2024
@luoping-12345 luoping-12345 force-pushed the identitycenter_attr_conf branch 4 times, most recently from 29b93e4 to 31de664 Compare December 17, 2024 03:41
@Alice1319
Copy link

LGTM

@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 17, 2024
@wuzhuanhong
Copy link
Contributor

LGTM

1 similar comment
@yuanxiaojun987
Copy link

LGTM

@luoping-12345 luoping-12345 force-pushed the identitycenter_attr_conf branch from 31de664 to 2a71f16 Compare December 19, 2024 06:08
@github-ci-robot github-ci-robot removed the LGTM /lgtm label Dec 19, 2024
@luoping-12345 luoping-12345 force-pushed the identitycenter_attr_conf branch from 2a71f16 to 252148b Compare December 19, 2024 06:59
@luoping-12345 luoping-12345 force-pushed the identitycenter_attr_conf branch from 252148b to c767355 Compare December 19, 2024 07:02
@Jason-Zhang9309
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Jason-Zhang9309

/approve

@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 20, 2024
@github-ci-robot github-ci-robot merged commit cb8885e into huaweicloud:master Dec 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants