Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspace/app): add data source to get list of the image servers #5922

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

wuzhuanhong
Copy link
Contributor

What this PR does / why we need it:

Add new datasource to get the list of the image server of the Workspace APP.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add new datasource to get image servers.
2. add correponding document and acceptance test.

PR Checklist

  • Tests added/passed.
$ ./scripts/coverage.sh -o workspace -f TestAccDataSourceAppImageServers_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDataSourceAppImageServers_basic -timeout 360m -parallel 10
=== RUN   TestAccDataSourceAppImageServers_basic
=== PAUSE TestAccDataSourceAppImageServers_basic
=== CONT  TestAccDataSourceAppImageServers_basic
--- PASS: TestAccDataSourceAppImageServers_basic (864.69s)
PASS
coverage: 7.6% of statements in ./huaweicloud/services/workspace
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 864.776s        coverage: 7.6% of statements in ./huaweicloud/services/workspace
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@wuzhuanhong wuzhuanhong force-pushed the image_servers branch 3 times, most recently from 6ba8e37 to 2bccf4b Compare November 29, 2024 01:23
@wuzhuanhong
Copy link
Contributor Author

./scripts/coverage.sh -o workspace -f TestAccDataSourceAppImageServers_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDataSourceAppImageServers_basic -timeout 360m -parallel 10
=== RUN TestAccDataSourceAppImageServers_basic
=== PAUSE TestAccDataSourceAppImageServers_basic
=== CONT TestAccDataSourceAppImageServers_basic
--- PASS: TestAccDataSourceAppImageServers_basic (956.65s)
PASS
coverage: 6.5% of statements in ./huaweicloud/services/workspace
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 956.721s coverage: 6.5% of statements in ./huaweicloud/services/workspace

@WangLiNaruto
Copy link

LGTM

@wuzhuanhong
Copy link
Contributor Author

./scripts/coverage.sh -o workspace -f TestAccDataSourceAppImageServers_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDataSourceAppImageServers_basic -timeout 360m -parallel 10
=== RUN TestAccDataSourceAppImageServers_basic
=== PAUSE TestAccDataSourceAppImageServers_basic
=== CONT TestAccDataSourceAppImageServers_basic
--- PASS: TestAccDataSourceAppImageServers_basic (778.37s)
PASS
coverage: 5.6% of statements in ./huaweicloud/services/workspace
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 778.439s coverage: 5.6% of statements in ./huaweicloud/services/workspace

@Lance52259
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 26, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 780ac76 into huaweicloud:master Dec 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants