Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iotda/device_binding_groups): support device binding groups data source #5801

Conversation

jinyangyang222
Copy link
Contributor

@jinyangyang222 jinyangyang222 commented Nov 1, 2024

What this PR does / why we need it:

Support device binding groups data source

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
$ export HW_IOTDA_ACCESS_ADDRESS=xxxxxxxxxxxxx

$ make testacc TEST="./huaweicloud/services/acceptance/iotda" TESTARGS="-run TestAccDataSourceDeviceBindingGroups_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/iotda -v -run TestAccDataSourceDeviceBindingGroups_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceDeviceBindingGroups_basic
=== PAUSE TestAccDataSourceDeviceBindingGroups_basic
=== CONT  TestAccDataSourceDeviceBindingGroups_basic
--- PASS: TestAccDataSourceDeviceBindingGroups_basic (13.46s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/iotda     13.509s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@jinyangyang222 jinyangyang222 force-pushed the feat-iotda/support-device_binding_groups-datasource branch 2 times, most recently from 826a200 to 3418d4d Compare November 1, 2024 03:00
@jinyangyang222 jinyangyang222 force-pushed the feat-iotda/support-device_binding_groups-datasource branch from 3418d4d to 793f54f Compare November 1, 2024 06:22
@jinyangyang222
Copy link
Contributor Author

make testacc TEST="./huaweicloud/services/acceptance/iotda" TESTARGS="-run TestAccDataSourceDeviceBindingGroups_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/iotda -v -run TestAccDataSourceDeviceBindingGroups_basic -timeout 360m -parallel 4
=== RUN TestAccDataSourceDeviceBindingGroups_basic
=== PAUSE TestAccDataSourceDeviceBindingGroups_basic
=== CONT TestAccDataSourceDeviceBindingGroups_basic
--- PASS: TestAccDataSourceDeviceBindingGroups_basic (14.04s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/iotda 14.085s

@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 1, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit c64b3b5 into huaweicloud:master Nov 1, 2024
14 checks passed
@jinyangyang222 jinyangyang222 deleted the feat-iotda/support-device_binding_groups-datasource branch January 15, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants