Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iotda): add resource to manage device asynchronous command deliver #5800

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

ruwenqiang123
Copy link
Contributor

What this PR does / why we need it:

Add resource to manage device asynchronous command deliver.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1.add resource to manage device asynchronous command deliver.
2.support related document and acceptance test.

PR Checklist

  • Tests added/passed.
$ make testacc TEST="./huaweicloud/services/acceptance/iotda" TESTARGS="-run TestAccDeviceAsyncCommand_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/iotda -v -run TestAccDeviceAsyncCommand_basic -timeout 360m -parallel 4
=== RUN   TestAccDeviceAsyncCommand_basic
--- PASS: TestAccDeviceAsyncCommand_basic (54.13s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/iotda     54.212s
$ make testacc TEST="./huaweicloud/services/acceptance/iotda" TESTARGS="-run TestAccDeviceAsyncCommand_derived"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/iotda -v -run TestAccDeviceAsyncCommand_derived -timeout 360m -parallel 4
=== RUN   TestAccDeviceAsyncCommand_derived
--- PASS: TestAccDeviceAsyncCommand_derived (57.10s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/iotda     57.190s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@ruwenqiang123 ruwenqiang123 force-pushed the dev_command branch 4 times, most recently from da91627 to a774786 Compare November 4, 2024 01:50
@ruwenqiang123 ruwenqiang123 force-pushed the dev_command branch 2 times, most recently from 6fb0951 to 1d5bffe Compare November 5, 2024 01:55
@ruwenqiang123
Copy link
Contributor Author

root@ecs-ruwenqiang:/home/huawei/go/src/github.com/huaweicloud/terraform-provider-huaweicloud (dev_command)$ make testacc TEST="./huaweicloud/services/acceptance/iotda" TESTARGS="-run TestAccDeviceAsyncCommand_derived"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/iotda -v -run TestAccDeviceAsyncCommand_derived -timeout 360m -parallel 4
=== RUN   TestAccDeviceAsyncCommand_derived
--- PASS: TestAccDeviceAsyncCommand_derived (55.93s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/iotda     55.979s

@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 5, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 09e451a into huaweicloud:master Nov 5, 2024
14 checks passed
@ruwenqiang123 ruwenqiang123 deleted the dev_command branch November 18, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants