Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two bugs for terraform-provider-huaweicloud #225

Merged
merged 4 commits into from
Nov 6, 2019
Merged

Fix two bugs for terraform-provider-huaweicloud #225

merged 4 commits into from
Nov 6, 2019

Conversation

ShiChangkuo
Copy link
Collaborator

  1. update github.com/Unknwon/com to github.com/unknwon/com, this patch could fix Potential case-insensitive import collision #178
  2. Logging fault message when build compute instance failed

@ShiChangkuo
remove github.com/Unknwon/com in vendor
9166bcb 
github.com/Unknwon/com has changed to github.com/unknwon/com

Signed-off-by: ShiChangkuo <[email protected]>
@ShiChangkuo
add github.com/unknwon/com in vendor
f215e94 
github.com/Unknwon/com has changed to github.com/unknwon/com

Signed-off-by: ShiChangkuo <[email protected]>
@ShiChangkuo
import github.com/unknwon/com in related files
979572e 
due to github.com/Unknwon/com has changed to github.com/unknwon/com,
we should re-import it in huaweicloud/util.go
@ShiChangkuo
Log fault message when build compute instance failed
d221053
@niuzhenguo niuzhenguo merged commit 93b2d63 into huaweicloud:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies on API size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential case-insensitive import collision
2 participants
@ShiChangkuo @niuzhenguo