New MRS v2 job resource #1327
Merged
New MRS v2 job resource #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmbig2
reviewed
Aug 4, 2021
| Required: true, | ||
| ForceNew: true, | ||
| ValidateFunc: validation.StringInSlice([]string{ | ||
| "Flink", "HiveSql", "HiveScript", "MapReduce", "SparkSubmit", "SparkSql", "SparkScript", |
There was a problem hiding this comment.
defined as a constant, it is more convenient to use, such as in test : resource.TestCheckResourceAttr(resourceName, "type", "SparkSubmit"),
hmbig2
reviewed
Aug 4, 2021
docs/resources/mapreduce_job.md
Outdated
|
|
||
| -> **NOTE:** Spark and Hive jobs can be added to only clusters including Spark and Hive components. | ||
|
|
||
| * `jar_path` - (Optional, String, ForceNew) Specifies the .jar package path for program execution. |
There was a problem hiding this comment.
when type =sparkSubmit
in the console webpage : this field label is "Program Path", support .jar or .py
- use constant to defind the job type - adjust document description - use program path to replace the jar path parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Compared with the job of V1 version, the parameter design of V2 version refers to the console, which makes it more convenient for users to use job resources against the console and integrate old parameters such as jar path into a program parameters dictionary.
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)reference: #1324
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed