Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppport remove in cce node #1314

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

Jason-Zhang9309
Copy link
Collaborator

@Jason-Zhang9309 Jason-Zhang9309 commented Jul 27, 2021

What this PR does / why we need it:

suppport remove in cce node

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
related #1178

Special notes for your reviewer:

Release note:

A new bool type parameter `keep_ecs` is added.
If it's set to true, the ecs server won't be deleted when deleting the cce node.

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccSomethingV0_basic'
...
=== RUN   TestAccSomethingV0_basic
--- PASS: TestAccSomethingV0_basic (70.75s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       70.796s

@ShiChangkuo ShiChangkuo merged commit a8cf883 into huaweicloud:master Jul 28, 2021
@Jason-Zhang9309 Jason-Zhang9309 deleted the dev-cce-node branch August 4, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants