support iam role for cloud services and agencies

docs/resources/identity_role.md

@@ -2,11 +2,11 @@
 subcategory: "Identity and Access Management (IAM)"
 ---
 
-# huaweicloud\_identity\_role
+# huaweicloud_identity_role
 
 Manages a **Custom Policy** resource within HuaweiCloud IAM service.
 
-Note: You _must_ have admin privileges in your HuaweiCloud cloud to use
+->**Note** You _must_ have admin privileges in your HuaweiCloud cloud to use
 this resource.
 
 ## Example Usage

huaweicloud/resource_huaweicloud_identity_role.go

@@ -132,7 +132,7 @@ func resourceIdentityRoleUpdate(d *schema.ResourceData, meta interface{}) error
 		Policy:      policy,
 	}
 
-	logp.Printf("[DEBUG] Create Options: %#v", createOpts)
+	logp.Printf("[DEBUG] Update Options: %#v", createOpts)
 
 	_, err = policies.Update(identityClient, d.Id(), createOpts).Extract()
 	if err != nil {

huaweicloud/resource_huaweicloud_identity_role_test.go

@@ -55,6 +55,37 @@ func TestAccIdentityRole_basic(t *testing.T) {
 	})
 }
 
+func TestAccIdentityRole_agency(t *testing.T) {
+	var role policies.Role
+	var roleName = fmt.Sprintf("tf-acc-test-%s", acctest.RandString(5))
+	resourceName := "huaweicloud_identity_role.agency"
+
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck: func() {
+			testAccPreCheck(t)
+			testAccPreCheckAdminOnly(t)
+		},
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckIdentityRoleDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccIdentityRole_agency(roleName),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckIdentityRoleExists(resourceName, &role),
+					resource.TestCheckResourceAttrPtr(resourceName, "name", &role.Name),
+					resource.TestCheckResourceAttrPtr(resourceName, "description", &role.Description),
+					resource.TestCheckResourceAttr(resourceName, "type", "AX"),
+				),
+			},
+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
+
 func testAccCheckIdentityRoleDestroy(s *terraform.State) error {
 	config := testAccProvider.Meta().(*config.Config)
 	identityClient, err := config.IAMV3Client(HW_REGION_NAME)
@@ -166,3 +197,32 @@ EOF
 }
 `, roleName, HW_REGION_NAME)
 }
+
+func testAccIdentityRole_agency(roleName string) string {
+	return fmt.Sprintf(`
+resource "huaweicloud_identity_role" agency {
+  name        = "%s"
+  description = "created by terraform"
+  type        = "AX"
+  policy      = <<EOF
+{
+  "Version": "1.1",
+  "Statement": [
+    {
+      "Effect": "Allow",
+      "Action": [
+        "iam:agencies:assume"
+      ],
+      "Resource": {
+        "uri": [
+          "/iam/agencies/07805aca-ba80-0fdd-4fbd-c00b8f888c7c",
+          "/iam/agencies/16d4d672-8665-496e-a0b5-71a8ad7f2fe8"
+        ]
+      }
+    }
+  ]
+}
+EOF
+}
+`, roleName)
+}