Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source for Dedicated ELB certificates. #1301

Merged

Conversation

chengxiangdong
Copy link
Collaborator

What this PR does / why we need it:

I'd like to add data source for Dedicated ELB Certificates.
huaweicloud_elb_certificate

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #1264

Special notes for your reviewer:

  • The SDK of ELB V3 has been imported to vendor.
  • The parameters are the same as the WAF certificate data source parameters.
  • Only our test account can use the Dedicated ELB services in Beijing4 region.

Release note:

NONE

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud/services/acceptance/elb' TESTARGS='-run TestAccDataSourceELbCertificateV3_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/elb -v -run TestAccDataSourceELbCertificateV3_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceELbCertificateV3_basic
--- PASS: TestAccDataSourceELbCertificateV3_basic (10.01s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/elb       10.088s

@chengxiangdong chengxiangdong force-pushed the feat_elb_certificate_query branch from 92eb6e4 to 3030130 Compare July 22, 2021 11:52
@ShiChangkuo ShiChangkuo merged commit da965c4 into huaweicloud:master Jul 23, 2021
@chengxiangdong chengxiangdong deleted the feat_elb_certificate_query branch July 23, 2021 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ELB] Add data source for certificates
2 participants