add resource dms_kafka_instance #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jason-Zhang9309
force-pushed
the
dev-dms-kafka
branch
from
6fc0ad6 to
1f09fcf
Compare
ShiChangkuo
reviewed
May 25, 2021
docs/resources/dms_kafka_instance.md
Outdated
|
|
||
| * `product_id` - (Required, String, ForceNew) Specifies a product ID. Changing this creates a new instance resource. | ||
|
|
||
| * `kafka_manager_user` - (Required, String, ForceNew) Specifies the username for logging in to the Kafka Manager. |
There was a problem hiding this comment.
suggest to rename it to manager_user
docs/resources/dms_kafka_instance.md
Outdated
| - `time_base`: Automatically delete the earliest messages. | ||
| - `produce_reject`: Stop producing new messages. | ||
|
|
||
| * `connector_enable` - (Optional, Bool, ForceNew) Specifies whether to enable dumping. |
There was a problem hiding this comment.
suggest rename it to dumping to keep with the console
docs/resources/dms_kafka_instance.md
Outdated
Comment on lines
170
to
171
| - `true`: enable | ||
| - `false`: disable |
There was a problem hiding this comment.
we can set the value to true of false for a bool type, so the two lines are redundant.
docs/resources/dms_kafka_instance.md
Outdated
|
|
||
| Changing this creates a new instance resource. | ||
|
|
||
| * `partition_num` - (Required, Int, ForceNew) Specifies the maximum number of topics in the DMS kafka instance. |
There was a problem hiding this comment.
if the value depends on specification, we can use it as an internal parameter or set it as an attribute
| Computed: true, | ||
| ForceNew: true, | ||
| }, | ||
| "storage_spec_code": { |
There was a problem hiding this comment.
put the required field in the head of the schema
docs/resources/dms_kafka_instance.md
Outdated
Comment on lines
195
to
196
| * `user_id` - Indicates a user ID. | ||
| * `user_name` - Indicates a username. |
There was a problem hiding this comment.
tenant user id or the kafka user id?
| specification := d.Get("specification").(string) | ||
| publicIpIDsRaw := d.Get("public_ip_ids").([]interface{}) | ||
|
|
||
| if specification == "100MB" && len(publicIpIDsRaw) != 3 { |
There was a problem hiding this comment.
using a map will be more clearer
Jason-Zhang9309
force-pushed
the
dev-dms-kafka
branch
from
1f09fcf to
bf36ed8
Compare
Jason-Zhang9309
force-pushed
the
dev-dms-kafka
branch
from
bf36ed8 to
17944c8
Compare
|
latest test result: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add resource dms_kafka_instance
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)related #1052
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed