Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make list instead of set for ids of vpc data source #1142

Merged
merged 1 commit into from
May 19, 2021

Conversation

niuzhenguo
Copy link
Member

@niuzhenguo niuzhenguo commented May 18, 2021

What this PR does / why we need it:

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #1141

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST=./huaweicloud/ TESTARGS='-run=TestAccVpcIdsV1DataSource'
...
=== RUN   TestAccVpcIdsV1DataSource_basic
=== PAUSE TestAccVpcIdsV1DataSource_basic
=== CONT  TestAccVpcIdsV1DataSource_basic
--- PASS: TestAccVpcIdsV1DataSource_basic (109.59s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       109.618s

make testacc TEST=./huaweicloud/ TESTARGS='-run=TestAccVpcRouteIdsV2DataSource'
...
=== RUN   TestAccVpcRouteIdsV2DataSource_basic
=== PAUSE TestAccVpcRouteIdsV2DataSource_basic
=== CONT  TestAccVpcRouteIdsV2DataSource_basic
--- PASS: TestAccVpcRouteIdsV2DataSource_basic (218.21s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       218.235s

make testacc TEST=./huaweicloud/ TESTARGS='-run=TestAccVpcSubnetIdsV2DataSource'
...
=== RUN   TestAccVpcSubnetIdsV2DataSource_basic
=== PAUSE TestAccVpcSubnetIdsV2DataSource_basic
=== CONT  TestAccVpcSubnetIdsV2DataSource_basic
--- PASS: TestAccVpcSubnetIdsV2DataSource_basic (201.55s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       201.573s

@niuzhenguo niuzhenguo merged commit 489d2e2 into huaweicloud:master May 19, 2021
@niuzhenguo niuzhenguo deleted the fix-vpc branch May 19, 2021 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vpc data source ids: make list instead of set
1 participant