Power action parameter and method supported #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lance52259
changed the title
ShiChangkuo
reviewed
May 18, 2021
| // If you want to support more actions, please update powerActionMap simultaneously. | ||
| ValidateFunc: validation.StringInSlice([]string{ | ||
| "ON", "OFF", "REBOOT", "FORCE-OFF", "FORCE-REBOOT", | ||
| }, true), |
There was a problem hiding this comment.
seems the ignoreCase shoud be false.
There was a problem hiding this comment.
case ignore is set false now
| @@ -631,6 +639,17 @@ func resourceComputeInstanceV2Create(d *schema.ResourceData, meta interface{}) e | |||
| } | |||
| } | |||
|
|
|||
| // Create an instance in the shutdown state. | |||
| if action, ok := d.GetOk("power_action"); ok { | |||
| if action.(string) != "OFF" { | |||
There was a problem hiding this comment.
FORCE-OFF should also be valid during the creation.
There was a problem hiding this comment.
thx, the FORCE-OFF has added
| log.Printf("[WARN] The power action (%s) is invalid after instance created", action.(string)) | ||
| } else { | ||
| if err = doPowerAction(ecsClient, d, action.(string)); err != nil { | ||
| return fmt.Errorf("Unable to close the huaweicloud compute instance (%s): %s", d.Id(), err) |
There was a problem hiding this comment.
the error message shoud be updated.
There was a problem hiding this comment.
The message has updated.
ShiChangkuo
reviewed
May 19, 2021
docs/resources/compute_instance.md
Outdated
| @@ -283,6 +283,10 @@ The following arguments are supported: | |||
| * `agency_name` - (Optional, String, ForceNew) Specifies the IAM agency name which is created on IAM to provide | |||
| temporary credentials for ECS to access cloud services. Changing this creates a new instance. | |||
|
|
|||
| * `power_action` - (Optional, String) Specifies what action needs to be done for the instance. | |||
There was a problem hiding this comment.
Specifies the power action to be done for ...
There was a problem hiding this comment.
The description has updated, and the note info The power_action is a one-time action. is better than The power_action parameter specifies a one-time action.?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #914
fixes #1044
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed