Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] New load balancer data source supported #1113

Merged
merged 1 commit into from
May 11, 2021
Merged

[Feature Request] New load balancer data source supported #1113

merged 1 commit into from
May 11, 2021

Conversation

Lance52259
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #1107

Special notes for your reviewer:

Release note:

1. support new load balancer data source to fetching specifies load balancer.
2. support new load balancer acc test.
3. support new load balancer document.

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccELBV2LoadbalancerDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run=TestAccELBV2LoadbalancerDataSource_basic -timeout 360m -parallel 4
=== RUN   TestAccELBV2LoadbalancerDataSource_basic
=== PAUSE TestAccELBV2LoadbalancerDataSource_basic
=== CONT  TestAccELBV2LoadbalancerDataSource_basic
--- PASS: TestAccELBV2LoadbalancerDataSource_basic (55.54s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       55.604s


In addition to all arguments above, the following attributes are exported:

* `admin_state_up` - The administrative status of the load balancer.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to deprecate admin_state_up, loadbalancer_provider, security_group_ids and tenant_id

@ShiChangkuo ShiChangkuo merged commit 9e96285 into huaweicloud:master May 11, 2021
@Lance52259 Lance52259 deleted the br_lb_datasource_active branch May 11, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] [ELB] Data sources for huaweicloud_elb_loadbalancer ressource
2 participants