Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename xrole and app arguments for fgs #1095

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Conversation

niuzhenguo
Copy link
Member

@niuzhenguo niuzhenguo commented Apr 30, 2021

What this PR does / why we need it:
It's a bit confused that app means package in terrafrom and agency means xrole

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #1076

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

TF_ACC=1 go test ./huaweicloud/ -v -run=TestAccFgsV2Function_basic -timeout 360m -parallel 4
=== RUN   TestAccFgsV2Function_basic
=== PAUSE TestAccFgsV2Function_basic
=== CONT  TestAccFgsV2Function_basic
--- PASS: TestAccFgsV2Function_basic (56.48s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       56.499s


It's a bit confused that app means package in terrafrom and
agency means xrole
@niuzhenguo niuzhenguo merged commit f825b4a into huaweicloud:master Apr 30, 2021
@niuzhenguo niuzhenguo deleted the fgs branch April 30, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FunctionGraph] Rename xrole and app arguments
1 participant