Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subnet resource and data source supports ipv6 id #1017

Merged
merged 2 commits into from
Apr 1, 2021
Merged

Subnet resource and data source supports ipv6 id #1017

merged 2 commits into from
Apr 1, 2021

Conversation

Lance52259
Copy link
Contributor

What this PR does / why we need it:
The subnet id is missing in the subnet of ipv6.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
reference: #989

Special notes for your reviewer:

Release note:

1. new ipv6_subnet_id parameter.

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccVpcSubnetV1_ipv6'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run=TestAccVpcSubnetV1_ipv6 -timeout 360m -parallel 4
=== RUN   TestAccVpcSubnetV1_ipv6
=== PAUSE TestAccVpcSubnetV1_ipv6
=== CONT  TestAccVpcSubnetV1_ipv6
--- PASS: TestAccVpcSubnetV1_ipv6 (96.39s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       96.452s

@ShiChangkuo ShiChangkuo self-requested a review March 31, 2021 03:04
@@ -61,6 +61,8 @@ In addition to all arguments above, the following attributes are exported:

* `ipv6_enable` - Whether the IPv6 is enabled.

* `ipv6_subnet_id` - The ID of the IPv6 subnet. If the subnet is an IPv4 subnet, this parameter is not returned.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove If the subnet is an IPv4 subnet, this parameter is not returned. ? I think it is unnecessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, other IPv6 parameters also have this description.
None of them make sense.

@ShiChangkuo ShiChangkuo merged commit 6facba0 into huaweicloud:master Apr 1, 2021
@Lance52259 Lance52259 deleted the br_subnet_IPv6_ID_active branch April 2, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants