Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem that code param are not mandatory in DCS data sources #1016

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Fix the problem that code param are not mandatory in DCS data sources #1016

merged 1 commit into from
Mar 31, 2021

Conversation

Lance52259
Copy link
Contributor

What this PR does / why we need it:
The results of huaweicloud_dcs_az data source are always the same.

  • After reading dcs available zones from server, huaweicloud_dcs_az doesn‘t use the code parameter for verification.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #990

Special notes for your reviewer:

Release note:

1. add the 'code' to the verification step.

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

NONE

@Lance52259 Lance52259 self-assigned this Mar 31, 2021
@ShiChangkuo ShiChangkuo self-requested a review March 31, 2021 02:44
Copy link
Collaborator

@ShiChangkuo ShiChangkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiChangkuo ShiChangkuo merged commit f4d5ad8 into huaweicloud:master Mar 31, 2021
@Lance52259 Lance52259 deleted the br_dcs_az_code_active branch May 11, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

huaweicloud_dcs_az data source is always the same
2 participants