CCE cluster supports deleting associated resources #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Lance52259 the docs should also be updated |
ShiChangkuo
reviewed
Mar 29, 2021
docs/resources/cce_cluster.md
Outdated
| @@ -163,6 +163,26 @@ The following arguments are supported: | |||
| * `enterprise_project_id` - (Optional, String, ForceNew) The enterprise project id of the cce cluster. | |||
| Changing this creates a new cluster. | |||
|
|
|||
| * `delete_efs` - (Optional, String) Specified whether to delete the associated EFS resources. | |||
There was a problem hiding this comment.
it's better to be described as Specified whether to delete the associated EFS resources when deleting the CCE cluster.
ShiChangkuo
reviewed
Mar 29, 2021
| @@ -242,6 +253,16 @@ func ResourceCCEClusterV3() *schema.Resource { | |||
| } | |||
| } | |||
|
|
|||
| var associateDeleteSchema *schema.Schema = &schema.Schema{ | |||
There was a problem hiding this comment.
suggest to put the variable at the head of this file.
docs/resources/cce_cluster.md
Outdated
| @@ -163,6 +163,27 @@ The following arguments are supported: | |||
| * `enterprise_project_id` - (Optional, String, ForceNew) The enterprise project id of the cce cluster. | |||
| Changing this creates a new cluster. | |||
|
|
|||
| * `delete_efs` - (Optional, String) Specified whether to delete the associated EFS resources when deleting CCE cluster. | |||
| valid value are "true", "try" and "false". Default is false. | |||
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
CCE API supports deleting the associated resources when deleting an cluster now.
the associated resources contains:
In addition to the separate resource deletion option, it also supports the deletion of all the associated items of the above resources.
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed