Allow a conn open ack to succeed in the happy case (informalsystems#700)

* Allow a conn open ack to succeed

* Remove invalid test

* update CHANGELOG

* Make MsgConnectionOpenAck.counterparty_connection_id not an Option

CHANGELOG.md

@@ -34,6 +34,7 @@
 
 - [ibc]
   - Fix overflow bug in ICS03 client consensus height verification method ([#685])
+  - Allow a conn open ack to succeed in the happy case ([#699])
 
 - [ibc-relayer]
   - [nothing yet]
@@ -44,7 +45,7 @@
 ### BREAKING CHANGES
 
 - [ibc]
-  - [nothing yet]
+  - `MsgConnectionOpenAck.counterparty_connection_id` is now a `ConnectionId` instead of an `Option<ConnectionId>`([#700])
 
 - [ibc-relayer]
   - [nothing yet]
@@ -55,6 +56,8 @@
 [#599]: https://github.com/informalsystems/ibc-rs/issues/599
 [#685]: https://github.com/informalsystems/ibc-rs/issues/685
 [#689]: https://github.com/informalsystems/ibc-rs/issues/689
+[#699]: https://github.com/informalsystems/ibc-rs/issues/699
+[#700]: https://github.com/informalsystems/ibc-rs/pull/700
 
 ## v0.1.1
 *February 17, 2021*

relayer/src/connection.rs

@@ -566,7 +566,7 @@ impl Connection {
 
         let new_msg = MsgConnectionOpenAck {
             connection_id: self.dst_connection_id().clone(),
-            counterparty_connection_id: Option::from(self.src_connection_id().clone()),
+            counterparty_connection_id: self.src_connection_id().clone(),
             client_state,
             proofs,
             version: src_connection.versions()[0].clone(),