Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop revisions #161

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Develop revisions #161

merged 6 commits into from
Feb 1, 2024

Conversation

nizomovs
Copy link
Contributor

Addresses #142. The develop revisions checkout logic is now as follows:

  1. if the repository has not been cloned yet:
    1. run git clone <repo_url>
    2. run git checkout <branch_name>, where branch_name is the build_version specified in the experiments.yml
  2. if the repository has already been cloned:
    1. if there are local changes using (checked using git status --porcelain):
      1. if the force/confirmation flag (-f) has been set: checkout given branch by running git checkout <branch_name>
      2. if the force/confirmation flag has not been set: warn the user of local changes and refer to the force/confirmation flag
    2. if there are no local changes: checkout given branch by running git checkout <branch_name>

@nizomovs nizomovs requested a review from c-bebop January 30, 2024 17:33
simexpal/build.py Outdated Show resolved Hide resolved
simexpal/build.py Outdated Show resolved Hide resolved
simexpal/build.py Outdated Show resolved Hide resolved
simexpal/build.py Outdated Show resolved Hide resolved
simexpal/build.py Outdated Show resolved Hide resolved
simexpal/build.py Outdated Show resolved Hide resolved
simexpal/build.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@c-bebop c-bebop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@c-bebop c-bebop merged commit 6dfbb2e into hu-macsy:master Feb 1, 2024
10 checks passed
c-bebop added a commit to c-bebop/simexpal that referenced this pull request Feb 2, 2024
c-bebop added a commit that referenced this pull request Feb 2, 2024
Revert "Merge pull request #161 from nizomovs/develop-revisions"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants