Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for multiple headers with the same name in sessions #1335

Merged
merged 7 commits into from
Apr 3, 2022

Conversation

isidentical
Copy link
Contributor

Fixes #1331

@isidentical isidentical marked this pull request as ready for review March 30, 2022 12:35
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2022

Codecov Report

Merging #1335 (6d8ee7f) into master (4d7d6b6) will decrease coverage by 0.45%.
The diff coverage is 96.14%.

@@            Coverage Diff             @@
##           master    #1335      +/-   ##
==========================================
- Coverage   97.28%   96.83%   -0.46%     
==========================================
  Files          67       96      +29     
  Lines        4235     6821    +2586     
==========================================
+ Hits         4120     6605    +2485     
- Misses        115      216     +101     
Impacted Files Coverage Δ
tests/test_binary.py 100.00% <ø> (ø)
httpie/compat.py 31.11% <27.90%> (-68.89%) ⬇️
tests/conftest.py 77.14% <61.53%> (-9.82%) ⬇️
httpie/manager/__main__.py 82.35% <82.35%> (ø)
httpie/output/lexers/metadata.py 82.35% <82.35%> (ø)
httpie/output/lexers/http.py 86.36% <86.36%> (ø)
tests/test_ssl.py 92.66% <87.50%> (-2.28%) ⬇️
httpie/models.py 95.19% <90.00%> (-2.18%) ⬇️
httpie/manager/tasks/sessions.py 92.45% <92.45%> (ø)
tests/test_uploads.py 97.70% <92.59%> (-2.30%) ⬇️
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c157948...6d8ee7f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sessions doesn't support multiple headers sharing the same name
3 participants