Tests

httpie · Jun 6, 2024 · b3f9e01 · b3f9e01
1 parent 4747669
commit b3f9e01
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/tests/test_sessions.py b/tests/test_sessions.py
@@ -251,7 +251,7 @@ def test_session_default_header_value_overwritten(self, httpbin):
     def test_download_in_session(self, tmp_path, httpbin):
         # https://github.com/httpie/cli/issues/412
         self.start_session(httpbin)
-        with cd_clean_tmp_dir():
+        with cd_clean_tmp_dir(assert_filenames_after=['get.json']):
             http('--session=test', '--download',
                  httpbin + '/get', env=self.env())
 

diff --git a/tests/utils/__init__.py b/tests/utils/__init__.py
@@ -474,15 +474,15 @@ def dump_stderr():
 
 
 @contextlib.contextmanager
-def cd_clean_tmp_dir(assert_filenames_after: list = None):
-    """Run commands inside a clean temporary directory, optionally checking for created file names."""
+def cd_clean_tmp_dir(assert_filenames_after = []):
+    """Run commands inside a clean temporary directory, and verify created file names."""
     orig_cwd = os.getcwd()
     with tempfile.TemporaryDirectory() as tmp_dirname:
         os.chdir(tmp_dirname)
         assert os.listdir('.') == []
         try:
             yield tmp_dirname
-            if assert_filenames_after is not None:
-                assert os.listdir('.') == assert_filenames_after
+            actual_filenames = os.listdir('.')
+            assert actual_filenames == assert_filenames_after, (actual_filenames, assert_filenames_after)
         finally:
             os.chdir(orig_cwd)